volcano
volcano copied to clipboard
volcano-sh
add ut for enqueue action
What type of PR is this?
/kind feature
What this PR does / why we need it:
- add ut for action: enqueue
Which issue(s) this PR fixes:
Fixes #https://github.com/volcano-sh/volcano/issues/3053
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Are there any cases about job can not enqueue?
I added two type case, one: when pg is in running state, it will not join the queue, and the second one is when the specified queue does not exist, it will not join the queue.
How about queue's allocation plus the incoming inqueue's resource will exceed queue's capacity?
How about queue's allocation plus the incoming inqueue's resource will exceed queue's capacity?
Yes, I thought about this case. I thought that these scenarios would be covered by the plugins test cases, so I did not add these cases. If needed, I can add it.
How about queue's allocation plus the incoming inqueue's resource will exceed queue's capacity?
If needed, I can add it.
I advise to add some cases.
How about queue's allocation plus the incoming inqueue's resource will exceed queue's capacity?
If needed, I can add it.
I advise to add some cases.
done, i add the case "pggroup cannot enqueue because queue resources are less than podgroup MinResources"
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lowang-bh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [lowang-bh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
