volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix: log when outputting preempt error

Open googs1025 opened this issue 1 year ago • 1 comments

What type of PR is this?

log when outputting preempt error

What this PR does / why we need it:

  • log when outputting preempt error:preempt should be an important method. If an error occurs, a log should be printed.
  • refector the judgment statement of allocate action to make it more readable

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

googs1025 avatar Apr 28 '24 12:04 googs1025

@lowang-bh @Monokaix /PTAL thanks!

googs1025 avatar May 21 '24 14:05 googs1025

/lgtm

lowang-bh avatar May 21 '24 14:05 lowang-bh

/lgtm

Monokaix avatar May 23 '24 03:05 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 23 '24 14:05 volcano-sh-bot