volcano icon indicating copy to clipboard operation
volcano copied to clipboard

add ut for pkg/controllers/job/plugins

Open googs1025 opened this issue 2 months ago • 6 comments

What type of PR is this?

unit test

What this PR does / why we need it:

  • add some unit test for pkg/controllers/job/plugins

Which issue(s) this PR fixes:

See more detail https://github.com/volcano-sh/volcano/issues/3053#issuecomment-2042837878

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

googs1025 avatar Apr 17 '24 15:04 googs1025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign shinytang6 You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Apr 17 '24 15:04 volcano-sh-bot

image

googs1025 avatar Apr 17 '24 15:04 googs1025

I noticed that the test coverage in pkg/controllers can be improved. I will submit separate PRs to enhance this aspect.

googs1025 avatar Apr 17 '24 15:04 googs1025

@hwdef @Monokaix /PTAL

googs1025 avatar Apr 24 '24 13:04 googs1025

@hwdef /PTAL thanks!

googs1025 avatar May 10 '24 05:05 googs1025