volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix preempt & reclaim shecduler plugin with PreemptPredicateFn

Open LivingCcj opened this issue 1 year ago • 6 comments

fix issue: https://github.com/volcano-sh/volcano/issues/3329

LivingCcj avatar Mar 22 '24 12:03 LivingCcj

/lgtm

Monokaix avatar Mar 28 '24 06:03 Monokaix

The url in description seems not exists: )

Monokaix avatar Mar 28 '24 06:03 Monokaix

The url in description seems not exists: )

thx for your reply, now has updated this url

LivingCcj avatar Mar 28 '24 07:03 LivingCcj

I don't recommend this changed. But I also have no good idea now -_-

lowang-bh avatar Mar 28 '24 09:03 lowang-bh

/lgtm

lowang-bh avatar Apr 17 '24 09:04 lowang-bh

/lgtm

Monokaix avatar May 07 '24 06:05 Monokaix

we need to add some uts to cover it.

lowang-bh avatar May 07 '24 07:05 lowang-bh

New changes are detected. LGTM label has been removed.

volcano-sh-bot avatar May 09 '24 04:05 volcano-sh-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 09 '24 04:05 volcano-sh-bot