volcano
volcano copied to clipboard
volcano-sh
helm chart: add container security context
This change adds container security context to admission, controller, scheduler Deployments and scheduler Job. Container security context is necessary in some restricted environments, e.g. in environment that employs Restricted Pod Security Standard as default.
Welcome @viktoriaas!
It looks like this is your first PR to volcano-sh/volcano 馃帀.
Thank you, and welcome to Volcano. :smiley:
Hi, please also update README Configuration field and use git commit -s to sign off your commit.
@Monokaix hi, I updated README and signed off the commits.
Please also rebase master and submit one clean pr with git squash : )
@Monokaix: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@Monokaix Hi, I tried to create one clean commit but ended up messing up my forked repo and somehow closing this issue 😅 I thought I would end up with one clean commit but there one merge I can't get rid of. I'm sorry for the mess, please let me know if it's okay this way or I should fix the merge. Thanks!
@Monokaix Hi, I tried to create one clean commit but ended up messing up my forked repo and somehow closing this issue 😅 I thought I would end up with one clean commit but there one merge I can't get rid of. I'm sorry for the mess, please let me know if it's okay this way or I should fix the merge. Thanks!
You can checkout a new local branch based on master and then cherry-pick your commit to it and force push your repo to remove the merge commit.
@Monokaix: Failed to re-open PR: state cannot be changed. There are no new commits on the viktoriaas:master branch.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi, please use make update-development-yaml and add code changes to make CI happy.
Hi @Monokaix , I synced my branch with upstream and then used make update-development-yaml. Hope it's okay!