volcano icon indicating copy to clipboard operation
volcano copied to clipboard

update go to 1.21

Open hwdef opened this issue 1 year ago • 3 comments

hwdef avatar Feb 18 '24 06:02 hwdef

/assign @lowang-bh @Monokaix

hwdef avatar Feb 18 '24 07:02 hwdef

/lgtm

lowang-bh avatar Feb 19 '24 06:02 lowang-bh

We'd better add some info like volcano has adapted k8s 1.29 and k8s has used go 1.21 and so we should keep consistent it. Also please update docker build base image to 1.21.

Monokaix avatar Mar 06 '24 07:03 Monokaix

We'd better add some info like volcano has adapted k8s 1.29 and k8s has used go 1.21 and so we should keep consistent it. Also please update docker build base image to 1.21.

Thanks for your suggestions. I fixed this

hwdef avatar Mar 24 '24 11:03 hwdef

/lgtm

lowang-bh avatar Mar 31 '24 08:03 lowang-bh

/lgtm

Monokaix avatar May 08 '24 03:05 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 09 '24 02:05 volcano-sh-bot