volcano icon indicating copy to clipboard operation
volcano copied to clipboard

test: add tests for package resourcequota plugin.

Open Subhasish-Behera opened this issue 2 years ago • 6 comments

partially fixes #3053 .

Add UTs for /volcano/pkg/scheduler/plugins/resourcequota/resourcequota.go

Subhasish-Behera avatar Feb 17 '24 19:02 Subhasish-Behera

Welcome @Subhasish-Behera!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Feb 17 '24 19:02 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign qiankunli You can assign the PR to them by writing /assign @qiankunli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Feb 17 '24 19:02 volcano-sh-bot

@Subhasish-Behera now we can use the pkg/scheduler/uthelper package to refact the UTs and clean code. please refer the examples: https://github.com/volcano-sh/volcano/pull/3341, https://github.com/volcano-sh/volcano/pull/3364

lowang-bh avatar Mar 29 '24 02:03 lowang-bh

@lowang-bh thanks for informing. will make the necessary changes to get this merged

Subhasish-Behera avatar Mar 29 '24 14:03 Subhasish-Behera

@Subhasish-Behera: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar May 07 '24 06:05 volcano-sh-bot

@Subhasish-Behera Hi, thank you for your contribution! The related functions have been merged. refer to: https://github.com/volcano-sh/volcano/pull/3452#event-12715627606

googs1025 avatar May 07 '24 07:05 googs1025

/close

lowang-bh avatar Jun 06 '24 13:06 lowang-bh

@lowang-bh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Jun 06 '24 13:06 volcano-sh-bot