volcano
volcano copied to clipboard
volcano-sh
Switch hostPath to emptyDir
Resolves #3298
hostPath should be avoided unless absolutely necessary as per the upstream k8s docs:
https://kubernetes.io/docs/concepts/storage/volumes/#hostpath
This change swaps the hostPath for an emptyDir allowing the tmp logs to be written to an ephemeral location.
emptyDir is preferable to not using a volume at all in case a users environment enforces Read Only Root Filesystems.
Since this log is already being written to /tmp it doesn't seem like there is a requirement to persist these logs using a PVC.
Welcome @strangiato!
It looks like this is your first PR to volcano-sh/volcano 馃帀.
Thank you, and welcome to Volcano. :smiley:
Hi, please also execute make update-development-yaml to make install/volcano-development.yaml upated too. And use git commit -s to submit your pr.
Signed the commit.
I also went ahead and ran make update-development-yaml. It did not generate any changes since I manually updated the volcano-development.yaml file.
Signed the commit.
I also went ahead and ran
make update-development-yaml. It did not generate any changes since I manually updated thevolcano-development.yamlfile.
Understood: )
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kumarankit999
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kumarankit999: changing LGTM is restricted to collaborators
In response to this:
Now emptyDir has been on the place of hostPath
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.