volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Will PodGroup ownerReference enhancement be implemented?

Open hy00nc opened this issue 2 years ago • 6 comments

What would you like to be added:

I want to use the owner reference setting that is mentioned in design doc, but seems it is not yet implemented. Do you have any plans for this? Thanks!

hy00nc avatar Jan 12 '24 03:01 hy00nc

Hi, what problem do you want to solve and what's your use case here. If you just want solve "Inqueue" problem mentioned in this doc, there is already a relevant PR that solved this problem.

Monokaix avatar Jan 17 '24 02:01 Monokaix

Hi, what problem do you want to solve and what's your use case here. If you just want solve "Inqueue" problem mentioned in this doc, there is already a relevant PR that solved this problem.

Hi @Monokaix , thanks for the response. My usecase is for Argo Workflow. The podgroups created by pods in argo workflow is not deleted until the workflow is deleted because of the ownerReference inheritance.

hy00nc avatar Jan 17 '24 02:01 hy00nc

Hi, what problem do you want to solve and what's your use case here. If you just want solve "Inqueue" problem mentioned in this doc, there is already a relevant PR that solved this problem.

Hi @Monokaix , thanks for the response. My usecase is for Argo Workflow. The podgroups created by pods in argo workflow is not deleted until the workflow is deleted because of the ownerReference inheritance.

Seems there is another way to solve that problem, can this pr provides some inspiration?

Monokaix avatar Jan 18 '24 03:01 Monokaix

Seems there is another way to solve that problem, can this pr provides some inspiration?

We can do similar stuff done for k8s native job in that PR for Argo Workflow, but I think adding a CRD from another project won't be desirable?

hy00nc avatar Jan 18 '24 03:01 hy00nc

Seems there is another way to solve that problem, can this pr provides some inspiration?

We can do similar stuff done for k8s native job in that PR for Argo Workflow, but I think adding a CRD from another project won't be desirable?

That's a good question, but the original design you metioned seems can not resolve it well, we should also come up with another way, like still based on dynamic api discovery but other implement?

Monokaix avatar Jan 23 '24 03:01 Monokaix

That's a good question, but the original design you metioned seems can not resolve it well, we should also come up with another way, like still based on dynamic api discovery but other implement?

You mean this one? There is an example on using Argo Workflow in the design doc. I guess this design includes api discovery? I'm not sure on how to implement, but only saw the design doc.

hy00nc avatar Jan 23 '24 03:01 hy00nc