Ensure Pod Share Stays Below Resource Limits

[jignyasamishra]

Fix: #3255

Description: This update resolves an issue related to Pod Share calculation within the resource limits. The prior implementation allowed the Pod Share to exceed the available resource capacity, potentially leading to resource overutilization. The modified logic now ensures that the Pod Share is accurately computed based on the maximum resource utilization found among CPU, memory, and init containers. If this calculated share exceeds the available resources, the code clamps it to a maximum value of one (1) to maintain stability and prevent overconsumption of resources. This enhancement guarantees that Pod Share remains within the confines of the available resources, mitigating any potential resource allocation inconsistencies or overusage scenarios.

Changes Made: Adjusted Pod Share calculation logic to consider maximum resource utilization. Implemented checks to ensure the computed Pod Share remains within available resource limits. Added validation to limit the Pod Share value to one (1) when necessary, preventing overutilization of resources.

[volcano-sh-bot]

Welcome @jignyasamishra!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. :smiley:

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign thor-wl You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Monokaix]

Welcome and thanks for your contribution！Will check this soon: )

[k82cn]

/ok-to-test

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Monokaix]

Thanks for your contribution, it has been fixed by https://github.com/volcano-sh/volcano/pull/3448 : )

[Monokaix]

/close

[volcano-sh-bot]

@Monokaix: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.