volcano-sh
parse job min member info
split from #3057 (commit-1st: refact jobinfo's calculation to a function)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign qiankunli
You can assign the PR to them by writing /assign @qiankunli in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
May I ask why do we put this piece of code out of the main function? Personally speaking, it is short and readable enough.
This is part of function to calculate job min resource (PR #3057). To let calculation function looks more compact.
But that PR seems can not be merged in few years, so I split the first small commit out. @Monokaix
May I ask why do we put this piece of code out of the main function? Personally speaking, it is short and readable enough.
This is part of function to calculate job min resource (PR #3057). To let calculation function looks more compact.
But that PR seems can not be merged in few years, so I split the first small commit out. @Monokaix
I think we can concern the original pr directly: )
@lowang-bh: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.