volcano icon indicating copy to clipboard operation
volcano copied to clipboard

:art: refactor buildPod in unit test

Open kingeasternsun opened this issue 2 years ago • 6 comments

Because the origin PR https://github.com/volcano-sh/volcano/pull/2982 has two much different and conflicts with the latest master, So I decided to reopen a new PR.

I found that the function BuildPod, BuildPodWithPVC, BuildBestEffortPod, BuildPodWithPriority have many dumplicate code, which could be refactor use Option code model.

kingeasternsun avatar Dec 07 '23 03:12 kingeasternsun

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign k82cn You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Dec 07 '23 03:12 volcano-sh-bot

/assign @k82cn

kingeasternsun avatar Dec 07 '23 03:12 kingeasternsun

hello @merryzhou @Thor-wl Will U review this please?

kingeasternsun avatar Dec 13 '23 11:12 kingeasternsun

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 17 '24 09:03 stale[bot]

@kingeasternsun: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Apr 08 '24 02:04 volcano-sh-bot

still need

kingeasternsun avatar Apr 28 '24 02:04 kingeasternsun