volcano
volcano copied to clipboard
:art: refactor buildPod in unit test
Because the origin PR https://github.com/volcano-sh/volcano/pull/2982 has two much different and conflicts with the latest master, So I decided to reopen a new PR.
I found that the function BuildPod, BuildPodWithPVC, BuildBestEffortPod, BuildPodWithPriority have many dumplicate code, which could be refactor use Option code model.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/assign @k82cn
hello @merryzhou @Thor-wl Will U review this please?
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@kingeasternsun: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
still need