volcano-sh
Update prepare-for-development doc
I ran into several issues when I was trying to develop on my Mac, so I think it's better to update it in case it happens again for future contributors:
- At first, I set up everything on my Mac which has an ARM64 chip. While it works on the sample, there are some parts of the unit tests kept failing, so I added
Recommended Operating Systemsto ask Mac developers to have a virtual machine. - Update the Go version in the doc.
- Replace a wrong project name (Istio) with Volcano.
- Change the link for installing docker, the original one is to install docker desktop while the docker engine is enough.
Welcome @hzq5477!
It looks like this is your first PR to volcano-sh/volcano 馃帀.
Thank you, and welcome to Volcano. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lowang-bh: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/assign @Monokaix plz help to merge it.
Which part of ut failed, is OS problem or ut itself?
/assign @Monokaix plz help to merge it.
Which part of ut failed, is OS problem or ut itself?
"there are some parts of the unit tests kept failing"
As I known, the gomonkey package has no permit to run on MAC.
/assign @Monokaix plz help to merge it.
Which part of ut failed, is OS problem or ut itself?
"there are some parts of the unit tests kept failing"
As I known, the
gomonkeypackage has no permit to run on MAC.
Has gomonkey been replaced after your ut refactor pr?
As I known, the
gomonkeypackage has no permit to run on MAC.Has gomonkey been replaced after your ut refactor pr?
Yes, it is not necessary now.