volcano
volcano copied to clipboard
fix: ssn JobValid
JobValid after ssn.Tiers and ssn.Configurations Initialization required
OnSessionOpen to register the function jobValidFns
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
related to #2946
Need to clean up other JobValid.
/lgtm
@william-wang please help review it. thanks.
please fix the conflict
Hi @wangzhipeng , could we push this PR forward by solving the conflict and squash the commits?
New changes are detected. LGTM label has been removed.
@lowang-bh done
@lowang-bh done
Hi, @wangzhipeng we'd better to use rebase and squash the four commits to only one. thanks.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@wangzhipeng: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.