volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix: ssn JobValid

Open wangzhipeng opened this issue 2 years ago • 11 comments

JobValid after ssn.Tiers and ssn.Configurations Initialization required

OnSessionOpen to register the function jobValidFns

wangzhipeng avatar Aug 29 '23 09:08 wangzhipeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign shinytang6 You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Aug 29 '23 09:08 volcano-sh-bot

related to #2946

Need to clean up other JobValid.

lowang-bh avatar Aug 29 '23 10:08 lowang-bh

/lgtm

lowang-bh avatar Aug 30 '23 02:08 lowang-bh

@william-wang please help review it. thanks.

lowang-bh avatar Dec 09 '23 09:12 lowang-bh

please fix the conflict

hwdef avatar Dec 09 '23 17:12 hwdef

Hi @wangzhipeng , could we push this PR forward by solving the conflict and squash the commits?

lowang-bh avatar Dec 21 '23 10:12 lowang-bh

New changes are detected. LGTM label has been removed.

volcano-sh-bot avatar Dec 22 '23 08:12 volcano-sh-bot

@lowang-bh done

wangzhipeng avatar Dec 22 '23 08:12 wangzhipeng

@lowang-bh done

Hi, @wangzhipeng we'd better to use rebase and squash the four commits to only one. thanks.

lowang-bh avatar Dec 22 '23 10:12 lowang-bh

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 17 '24 09:03 stale[bot]

@wangzhipeng: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Apr 08 '24 02:04 volcano-sh-bot