volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Published 20 hours ago • verified publisher icon volcano-sh

fix: task-topology plugin cannot handle the tasks whose name contains `-`

Open loheagn opened this issue 2 years ago • 13 comments

fix #2939

loheagn avatar Jun 27 '23 07:06 loheagn

Welcome @loheagn! It looks like this is your first PR to volcano-sh/volcano 🎉

volcano-sh-bot avatar Jun 27 '23 07:06 volcano-sh-bot

@wangyang0616 Please help me trigger the CI of this PR

hwdef avatar Jun 27 '23 07:06 hwdef

how about add some comments of the task name format in following codes. The task's name is from pod name which generate by job controlller.

		i := len(task.Name) - 1
		for ; task.Name[i] != '-'; i-- {
		}
		tmpTaskName := strings.TrimPrefix(task.Name[:i], jobNamePrefix)

FYI: https://github.com/volcano-sh/volcano/blob/ed5c215d415d98845949d0fde6707cab29621989/pkg/controllers/job/job_controller_util.go#L39

lowang-bh avatar Jul 14 '23 14:07 lowang-bh

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 16 '23 21:09 stale[bot]

@lowang-bh Hi, could help to reopen this pr? I forget to update this pr for a long time......

loheagn avatar Oct 15 '23 15:10 loheagn

/reopen

lowang-bh avatar Oct 23 '23 14:10 lowang-bh

@lowang-bh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Oct 23 '23 14:10 volcano-sh-bot

@loheagn Hi, are you still work on this?

Monokaix avatar Jan 29 '24 07:01 Monokaix

@loheagn Hi, are you still work on this?

@Monokaix Yes, but I dismiss the reopen event.....

I'll update the code recently.

loheagn avatar Jan 29 '24 10:01 loheagn

@Monokaix Hi, I fixed the CI and this pr is ready for review

loheagn avatar Feb 06 '24 02:02 loheagn

/lgtm

Monokaix avatar Feb 21 '24 01:02 Monokaix

hello, @Monokaix could we move this PR forward?

loheagn avatar Feb 28 '24 04:02 loheagn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Mar 08 '24 02:03 volcano-sh-bot