volcano
volcano copied to clipboard
volcano-sh
don't need gen-code anymore in this repo's code
Fix #2878, as it describes, it will generate codes in apis dir when run make verify at local env. Remove it from code becualse code-generate is move to apis repo.
/kind clean-up
I don't understand how this solution is related to issue. Don't we need verify gencode?
Becasue we are use apis in https://github.com/volcano-sh/apis, it doesn't need here any more.
The latest gen-code script is at https://github.com/volcano-sh/apis/blob/master/hack/update-codegen.sh.
Maybe we also need to remove hack/update-codegen.sh from this source code.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lowang-bh: The label(s) kind/clean-up cannot be applied. These labels are supported: ``
In response to this:
Fix #2878, as it describes, it will generate codes in apis dir when run make verify at local env. Remove it from code becualse code-generate is move to apis repo.
/kind clean-up
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
It occurs to me that we have a plan to move api repo to volcano staging dir, because these two repoes are closely linked. So I think move api to current repo is more meaningful, and then we will need this script.
If anyone is interested, welcome to contribute.
Related issue: https://github.com/volcano-sh/volcano/issues/2356
@lowang-bh: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.