volcano fix(app): Introduced flag to specify leader election behavious

resolve: https://github.com/volcano-sh/volcano/issues/2798

Apr 21 '23 09:04 CharlesQQ

Welcome @CharlesQQ! It looks like this is your first PR to volcano-sh/volcano 🎉

Apr 21 '23 09:04 volcano-sh-bot

I think we should do some checks between those three parameters

Apr 21 '23 10:04 lowang-bh

cc @wangyang0616

May 04 '23 01:05 CharlesQQ

I agree with @lowang-bh is suggestion that the input parameters need to be verified.

May 04 '23 02:05 wangyang0616

@lowang-bh @wangyang0616 there have the checks for three parameter in leaderelection package, so no need to check again.

https://github.com/volcano-sh/volcano/blob/86ff94129a1ea47cdd3389e1f58dc6a79948f55f/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go#L76-L109

May 04 '23 03:05 CharlesQQ

cc @wangyang0616

Jul 04 '23 01:07 CharlesQQ

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Dec 15 '23 05:12 stale[bot]

/reopen

Mar 25 '24 03:03 CharlesQQ

@CharlesQQ: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mar 25 '24 03:03 volcano-sh-bot

/lgtm

Apr 01 '24 11:04 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [william-wang]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Apr 01 '24 12:04 volcano-sh-bot