volcano icon indicating copy to clipboard operation
volcano copied to clipboard

activeDeadlineSeconds like capability in a job

Open FlyAIBox opened this issue 3 years ago • 23 comments

What would you like to be added:

A activeDeadlineSeconds-like capability in a job that limits the job survival time The job is not finished within the specified time

Why is this needed:

Avoid some long-running jobs that do not set up the completed exit mechanism

FlyAIBox avatar Apr 01 '23 08:04 FlyAIBox

There is a definition of ActiveDeadlineSeconds in the job of k8s, which can control the running time of the job. If Volcano also adds corresponding definitions and functions, users will be more flexible in using it. I vote for it.

wangyang0616 avatar Apr 02 '23 02:04 wangyang0616

Hello šŸ‘‹ Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! šŸ¤— If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar Aug 07 '23 05:08 stale[bot]

still need this

hwdef avatar Oct 11 '24 10:10 hwdef

/good-first-issue

hwdef avatar Oct 11 '24 10:10 hwdef

@hwdef: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Oct 11 '24 10:10 volcano-sh-bot

I am very interested in this issue, please assign it to me.

fengruotj avatar Oct 19 '24 09:10 fengruotj

/assign

fengruotj avatar Oct 19 '24 09:10 fengruotj

Please submit a design document first. We also had some discussions during last week's weekly meeting:

  1. Add more scenarios. (You can refer to kubernetes job)
  2. After the set time is reached, the vcjob status changes to complete

hwdef avatar Oct 21 '24 07:10 hwdef

Please submit a design document first. We also had some discussions during last week's weekly meeting:

  1. Add more scenarios. (You can refer to kubernetes job)
  2. After the set time is reached, the vcjob status changes to complete

ok, I got it, where is week's weekly meeting. I am very interested to join you.

fengruotj avatar Nov 02 '24 03:11 fengruotj

https://zoom.us/j/91804791393 Every Friday at 3pm

You can also add WeChat account k8s2222 to let her pull you into the group. Meeting announcements will be posted in the group

hwdef avatar Nov 04 '24 06:11 hwdef

@fengruotj Did you still work on this?

hwdef avatar Mar 12 '25 16:03 hwdef

@fengruotj @hwdef hello,could I join in? I finish one and want another

elysium-w avatar Mar 17 '25 08:03 elysium-w

@fengruotj Yes, you can. welcome

hwdef avatar Mar 17 '25 08:03 hwdef

/assign

elysium-w avatar Mar 17 '25 09:03 elysium-w

@hwdef I still don't know much about volcano source code, can you please help me clarify which functions this change will involve?or anything I should deep learn about volcano

elysium-w avatar Mar 17 '25 09:03 elysium-w

two parts:

  1. Modify api, I already submit a PR https://github.com/volcano-sh/apis/pull/138
  2. Modify controller code, The logic is similar to the job native to k8s, and we can learn from the logic of k8s

hwdef avatar Mar 17 '25 09:03 hwdef

First we need to submit a design document

hwdef avatar Mar 18 '25 02:03 hwdef

@hwdef sure,I need to comb the source code, determine the specific scope of impact

elysium-w avatar Mar 18 '25 02:03 elysium-w

/priority important-soon

Monokaix avatar Apr 11 '25 03:04 Monokaix

Hi, I’m a new contributor and would like to work on this issue. Can I take it?

Bhukya-Sriram avatar Jun 04 '25 19:06 Bhukya-Sriram

/assign

Bhukya-Sriram avatar Jun 04 '25 19:06 Bhukya-Sriram

@elysium-w Are you still doing this?

hwdef avatar Jun 09 '25 03:06 hwdef

@elysium-w Are you still doing this?

yes,I was busy in those month for find job and graduation,right now I already finish it temporarily,sorry for my slow progress,I'll try to finish it these days,no more than 5 days. I'm so sorry.

elysium-w avatar Jun 16 '25 10:06 elysium-w