volcano icon indicating copy to clipboard operation
volcano copied to clipboard

make update pod more descriptive

Open Monokaix opened this issue 3 years ago • 2 comments

UpdateStatus is usually used to update Status Spec, here is not this case, UpdateStatus need more RBAC setting because it's a sub resource, Update method is more descriptive here.

ref:

  • https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
  • https://github.com/kubernetes/kubernetes/issues/60845#issuecomment-370871217

Monokaix avatar Aug 27 '22 08:08 Monokaix

Welcome @Monokaix!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Aug 27 '22 08:08 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign k82cn You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Aug 27 '22 08:08 volcano-sh-bot

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 01 '22 13:11 stale[bot]