volcano-sh
Tune default weights for nodeOrder plugin
@kerthcet: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@hzxuzhonghu Can you help to review this? This PR helps to make the scheduling decisions more reasonable.
Thanks for your pr. please make the ci happy.
I think the CI is broken, all my prs are all failed. And I think I'm not a trust contributor now, but let me have a try.
/ok-to-test /retest
@kerthcet: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
Thanks for your pr. please make the ci happy.
I think the CI is broken, all my prs are all failed. And I think I'm not a trust contributor now, but let me have a try.
/ok-to-test /retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Some errors: flag provided but not defined: -ginkgo.grace-period, but I didn't find where we define the flag.
The ci is still failing
Thanks for responding, I think this is fixed by another PR https://github.com/volcano-sh/volcano/pull/2548, no one seems to have time in reviewing. @hzxuzhonghu
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think this is a very good feature, do you have time to review it? @jiangkaihua @william-wang
/lgtm
It is reasonable that Volcano kept the same dedault weight as kube-scheduler. like: https://github.com/kubernetes/kubernetes/blob/3742d14998fc41dd8c086e8d44cf6b50023c831e/pkg/scheduler/apis/config/v1/default_plugins.go#L33-L54
@kerthcet Can you rebase the PR to the latest master branch code for this private branch is out of date? I'll try to merge it. Thanks!
@kerthcet Can you rebase the PR to the latest master branch code for this private branch is out of date? I'll try to merge it. Thanks!
Done
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Thor-wl, william-wang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/plugins/OWNERS~~ [Thor-wl,william-wang]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment