volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Add the allocation policy for deserved in scenario guarantee

Open nulls-cell opened this issue 3 years ago • 3 comments

Add the allocation policy for deserved in scenario guarantee

nulls-cell avatar Aug 14 '22 08:08 nulls-cell

Welcome @liblikewhen!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Aug 14 '22 08:08 volcano-sh-bot

to fix this issue: https://github.com/volcano-sh/volcano/issues/2364

nulls-cell avatar Aug 19 '22 02:08 nulls-cell

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hzxuzhonghu You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Aug 22 '22 06:08 volcano-sh-bot

@jinzhejz please help to review this plugin, thanks :)

william-wang avatar Nov 04 '22 01:11 william-wang

Hi @liblikewhen , thanks for the commit.

I went through the code and the new plugin use guarantee and capability to calculate deserved of a queue and just ignore queue weight, it is similar with proportion plugin and it may be better to handle this issue in proportion.

Now there are several issues related to guarantee and proportion, so there is a plan to refactor volcano code to improve guarantee/capability in proportion plugin, I think we can disscuss it together if you‘re interested in it.

jinzhejz avatar Nov 08 '22 11:11 jinzhejz

yeah, I'm glad to join this discussion and the code development.

nulls-cell avatar Nov 08 '22 11:11 nulls-cell

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 07 '23 11:01 stale[bot]