volcano
volcano copied to clipboard
Add the allocation policy for deserved in scenario guarantee
Add the allocation policy for deserved in scenario guarantee
Welcome @liblikewhen!
It looks like this is your first PR to volcano-sh/volcano 馃帀.
Thank you, and welcome to Volcano. :smiley:
to fix this issue: https://github.com/volcano-sh/volcano/issues/2364
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jinzhejz please help to review this plugin, thanks :)
Hi @liblikewhen , thanks for the commit.
I went through the code and the new plugin use guarantee and capability to calculate deserved of a queue and just ignore queue weight, it is similar with proportion plugin and it may be better to handle this issue in proportion.
Now there are several issues related to guarantee and proportion, so there is a plan to refactor volcano code to improve guarantee/capability in proportion plugin, I think we can disscuss it together if you‘re interested in it.
yeah, I'm glad to join this discussion and the code development.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.