proportion remaining resource sub panic bugfix
#2364
as issue #2364 describe, when increasedDeserved is Is greater than sum of remaining and decreasedDeserved, Sub is panic.
That's because the requested resources plus the guarantee resources are greater than the total cluster resources. In this case, there are no more resources to allocate to the queue's deserved resource
Signed-off-by: hansong [email protected]
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold @qiankunli I tried to simulate the bug scenario according to the proportion plugin implementation. I found that the root reason seems to be here. We should rethink the relationship within the queue.attr. Please help take a look at that. Thanks!
/lgtm cancel
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.