volcano icon indicating copy to clipboard operation
volcano copied to clipboard
verified publisher icon volcano-sh

add volcano.sh/apis to staging dir

Open lucming opened this issue 3 years ago • 6 comments

solve #2356 i just move the volcano.sh/apis this project to volcano's staging directory，and changed go.mod to let volcano use its own staging package. i have some other questions:

  1. vendor dir should can deleted from volcano.sh/apis or not.
  2. volcano.sh/apis have some files seems not belongs to it,can we put that to another dir,for example https://github.com/volcano-sh/apis/blob/master/pkg/apis/helpers/helpers.go this file,if you guys think it's okay, I can bring up a pr later to do this.
  3. we are still missing a tool that can synchronize the staging directory to subprojects

lucming avatar Jul 15 '22 02:07 lucming

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign wpeng102 You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jul 15 '22 02:07 volcano-sh-bot

I think the synchronization tools are very important.

en,maybe we can refer to implementation of k8s,https://github.com/kubernetes/publishing-bot this project can push latest code of staging dir to it's subprojects

lucming avatar Jul 15 '22 03:07 lucming

I think the synchronization tools are very important.

en,maybe we can refer to implementation of k8s,https://github.com/kubernetes/publishing-bot this project can push latest code of staging dir to it's subprojects

Automatic syschronization is the key thing. Please get familar with k8s staging firstly.

william-wang avatar Jul 15 '22 07:07 william-wang

I think the synchronization tools are very important.

en,maybe we can refer to implementation of k8s,https://github.com/kubernetes/publishing-bot this project can push latest code of staging dir to it's subprojects

Automatic syschronization is the key thing. Please get familar with k8s staging firstly.

If we intend to do so, i will add the relevant configuration.

lucming avatar Jul 15 '22 07:07 lucming

If we intend to do so, i will add the relevant configuration.

We've been thinking about doing this for a long time but have no resource. Thanks for investigation, please continue working on this :). Here are some reference. https://github.com/kubernetes/kubernetes/tree/master/staging https://github.com/kubernetes/publishing-bot https://github.com/kubernetes/test-infra

william-wang avatar Jul 15 '22 07:07 william-wang

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 20 '22 17:09 stale[bot]