volcano icon indicating copy to clipboard operation
volcano copied to clipboard

support nodegroup as a plugin

Open qiankunli opened this issue 2 years ago • 3 comments

issue #1830 related pr #2224 design doc #2227 queue.spec.Affinity is ready by https://github.com/volcano-sh/apis/pull/72 and merged in master branch by #2319, so it is time to push the feature.

qiankunli avatar Jul 14 '22 06:07 qiankunli

Should add some code for testing?

hwdef avatar Jul 14 '22 08:07 hwdef

@qiankunli What's the model relationship between queue and nodegroup. Do we allow to configure two queues that affinity the same nodegroup?

william-wang avatar Aug 26 '22 06:08 william-wang

@qiankunli please help to add the UT, e2e :)

william-wang avatar Sep 30 '22 02:09 william-wang

What's the model relationship between queue and nodegroup.

queue and nodegroup are many-to-many relationships

Do we allow to configure two queues that affinity the same nodegroup?

yes

qiankunli avatar Oct 25 '22 02:10 qiankunli

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign qiankunli You can assign the PR to them by writing /assign @qiankunli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Oct 25 '22 03:10 volcano-sh-bot

Hi, How long is it available?

jiamin13579 avatar Nov 09 '22 12:11 jiamin13579

@qiankunli please make the ci happy.

william-wang avatar Dec 01 '22 07:12 william-wang

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 05 '23 04:02 stale[bot]

still need /reopen

hwdef avatar May 06 '23 10:05 hwdef

@hwdef: Reopened this PR.

In response to this:

still need /reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar May 06 '23 10:05 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from qiankunli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 06 '23 10:05 volcano-sh-bot

any process?

zhoushuke avatar May 12 '23 01:05 zhoushuke

any process? +1

heumsi avatar May 26 '23 09:05 heumsi

any process

kinderyj avatar Jun 05 '23 12:06 kinderyj

how to calculate the deserved resource in proportion plugin when hard bind queue and node? @qiankunli

zhaizhch avatar Jun 13 '23 08:06 zhaizhch

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Aug 12 '23 19:08 stale[bot]

Does this 1.8.0 version come with this plugin

chenxj1997 avatar Aug 31 '23 03:08 chenxj1997

This PR is replaced with a new PR #3132, so we close it.

william-wang avatar Nov 15 '23 08:11 william-wang