volcano should the logic of webhook-manager be separated into helm?

hi,just a little confused,i see some code about helm,why not create webhook through helm directly,and i see that we create webhook by running a job(webhook-manager). in this way, if we install volcano by helm, "helm uninstall" cannot completely uninstall all resources volcano related. we have to delete the webhook separately.

Jun 14 '22 07:06 lucming

I don't quite understand why it's designed this way.
Webhooks deployed via helm could not be removed when helm uninstalled is being resolved. https://github.com/volcano-sh/volcano/pull/2203

Jun 14 '22 07:06 hwdef

2. Webhooks deployed via helm could not be removed when helm uninstalled is being resolved. fix(deploy): add helm pre delete hook to delete orphan resources #2203

this change can delete old webhooks when we do "helm install",but actually we want is delete all resources volcano related when we do "helm uninstall"

Jun 14 '22 11:06 lucming

well, You can comment below this pr to suggest changes. But in fact, this does not solve the fundamental problem, because volcano deployed through kubectl apply will still have similar problems, and uninstalling the webhook is not clean. So it's better to have a fundamental solution to the problem. This problem has been bothering us for a while.

Jun 14 '22 13:06 hwdef

okay,i will take care of this pr,I feel that the fundamental problems is that there is no uniformity in the installation of resources related to the volcano itself, some are created through yaml files and some are created through programs.can we split the logic of webhook creation from webhook-manager?

Jun 15 '22 02:06 lucming

@lucming I do not have the authority to make these decisions, please contact the maintainers in the community.

Jun 15 '22 02:06 hwdef

okay，thanks for your reply :)

Jun 15 '22 02:06 lucming

Hello 👋 Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

Sep 20 '22 19:09 stale[bot]

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

Nov 26 '22 23:11 stale[bot]