volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Published 20 hours ago • verified publisher icon volcano-sh

support update maxretry

Open zbbkeepgoing opened this issue 2 years ago • 7 comments

Support update vcjob.maxRetry & vcjob.tasks[*].maxRetry and fix Issue: https://github.com/volcano-sh/volcano/issues/2238

Signed-off-by: Binbin Zou [email protected]

zbbkeepgoing avatar May 26 '22 12:05 zbbkeepgoing

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 26 '22 12:05 volcano-sh-bot

Thanks for this fix. I'm considering about the rationality of letting users update the maxtry of a vcjob. How do you think about that? @shinytang6 @william-wang @qiankunli

Thor-wl avatar May 27 '22 02:05 Thor-wl

Thanks for this fix. I'm considering the rationality of letting users to update the maxtry of a vcjob. How do you think about that? @shinytang6 @william-wang @qiankunli

Agree it. In addition, MaxRetry only works at the controller level, not at the scheduler level.

zbbkeepgoing avatar May 27 '22 03:05 zbbkeepgoing

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 30 '22 15:07 stale[bot]

@Thor-wl Some other ideas about this?

zbbkeepgoing avatar Aug 01 '22 03:08 zbbkeepgoing

@Thor-wl Some other ideas about this?

Hey. I've reviewed the PR and related issue. As what I understand, your original scenario is to support job priorityclass modification in the admission webhook controller. Right? If that, perhaps you can ping @merryzhou for a patch.

Thor-wl avatar Aug 01 '22 06:08 Thor-wl

@Thor-wl Some other ideas about this?

Hey. I've reviewed the PR and related issue. As what I understand, your original scenario is to support job priorityclass modification in the admission webhook controller. Right? If that, perhaps you can ping @merryzhou for a patch.

No, it is fix this issue https://github.com/volcano-sh/volcano/issues/2238. The essence here is, if we not support maxretry in admission webhook, we can't update vcjob though "kubectl apply -f vcjob.yaml".

@merryzhou Do you have time look it？

zbbkeepgoing avatar Aug 03 '22 02:08 zbbkeepgoing

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Oct 12 '22 10:10 stale[bot]