volcano-sh
Suggest to add a field to queue.spec indicating queue open or closed
What would you like to be added:
Add a field to queue.spec, by modifying this field, the queue can be turned on or off.
Why is this needed:
After adding this field, the user can open or close the queue through kubectl.
REF: #1687
optional name:
- switch: open/close
- state: open/close
- open: true/false
- ...
Can we delete all jobs fristly, and then delete the queue; we can handle those actions in QueueController, similar to namespace.
Can we delete all jobs fristly, and then delete the queue; we can handle those actions in
QueueController, similar to namespace.
It's really simpler, but I am worried that this will delete the job by mistake. What if when deleting a queue, check if there are still jobs in the queue, and refuse to delete the queue if there are jobs? I'm not sure which one to use, the one you said looks good and is more in line with the logic of kubernetes.
From api view, I think it's reasonable,
then we can use yaml to control queue state close or open, and I'm not sure the final UX for this. I hope just use kubectl apply yaml to set queue spec rather than kubectl volcano plugin or something.
Because we still need to allow users use API interfaces(golang API/java API) to set spec. The better way is use crd capability directly.
And we might want to think about the rleationship of original state and spec.state.
Hello 👋 Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗
