volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Published 20 hours ago • verified publisher icon volcano-sh

feat(outOfSync): tracks and re-synchronizes node when it becomes 'OutOfSync'

Open eggiter opened this issue 4 years ago • 8 comments

  • fix #1818.
  • A possible fix to the above issue:
    • Add a RateLimitingQueue to holds the not ready nodes and start a asynchronous thread to synchronize them.
    • The events of updateNode and removeTask will trigger the re-synchronization of the related nodes.
    • The synchronization of node will use the latest v1.Node and v1.Pod list( a list of pods located on the former node) from the informer cache to:
      • updates node;
      • removes unwanted tasks(unlikely) and adds missing tasks;

eggiter avatar Nov 02 '21 10:11 eggiter

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 26 '22 07:01 stale[bot]

/cc @shinytang6 @william-wang

Thor-wl avatar Feb 14 '22 12:02 Thor-wl

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Apr 15 '22 22:04 stale[bot]

/assign @Thor-wl @k82cn @shinytang6 @william-wang

eggiter avatar Apr 20 '22 08:04 eggiter

@eggiter Please help resolve the conflicts. Thanks!

Thor-wl avatar Apr 27 '22 01:04 Thor-wl

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign k82cn You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jun 13 '22 10:06 volcano-sh-bot

@eggiter Please help resolve the conflicts. Thanks!

Resolved. This is an important fix as discussed in https://github.com/volcano-sh/volcano/issues/1818#issuecomment-1102257005. PTAL! @Thor-wl @k82cn

eggiter avatar Jun 13 '22 11:06 eggiter

OK. Let me take a review recently. Thanks!

Thor-wl avatar Jun 13 '22 12:06 Thor-wl

@Thor-wl @k82cn

eggiter avatar Oct 24 '22 01:10 eggiter

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 24 '22 09:12 stale[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 14 '23 13:03 stale[bot]