apis icon indicating copy to clipboard operation
apis copied to clipboard

add a label key: TaskIndexKey = volcano.sh/task-index

Open shuaiyy opened this issue 2 years ago • 5 comments

the task pod has a label of task spec by TaskSpecKey = "volcano.sh/task-spec", while task index missed, it's useful for pod lbael selectors to select a task pod by it's spec and index

the issue is here: add label key volcano.sh/task-index #98

shuaiyy avatar Jan 18 '23 02:01 shuaiyy

Welcome @shuaiyy!

It looks like this is your first PR to volcano-sh/apis 馃帀.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Jan 18 '23 02:01 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign william-wang You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jan 18 '23 02:01 volcano-sh-bot

I don't quite understand this requirement. Do you have a more detailed explanation? Is there any place where this field is used?

I have updated the description.

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

shuaiyy avatar Jan 18 '23 07:01 shuaiyy

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

Can you provide the original requirement? Yes, this key has been added into the environment variables.

Thor-wl avatar Jan 19 '23 01:01 Thor-wl

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

Can you provide the original requirement? Yes, this key has been added into the environment variables.

Okay. I'm trying to use volcano to replace kubeflow training-operator in my ml-platform; the training-operator provide job-name|task-spec|task-index label in task pod, while volcano missed task-index.

our ml-platform need these label:

  1. mount env key TASK_INDEX, the key is used by users and it's hard to let them change to VC_TASK_INDEX
  2. create a service with pod selector for a spectific task pod, and then create an ingress; if users need to debug their task by http tools;
  3. watch task pod's change and sync some info to persist db.

in our scenes, the use of task-index label may not common to other volcano users, but I do think the pod label info task-index is common, should be provided no matter how users will use it

shuaiyy avatar Jan 19 '23 02:01 shuaiyy