apis
apis copied to clipboard
volcano-sh
add v1 api version
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lucming Have you combine this PR with the master branch of volcano.sh/volcano and take a fully UT and e2e test locally?
@lucming Have you combine this PR with the master branch of volcano.sh/volcano and take a fully UT and e2e test locally?
en,volcano.sh/volcano this project changed too much,i want check more,and i will make a pr latter
It generally LGTM to me. Please mind the compatibility for users who are still making use of low versions.
okay,i will pay more attention to it,thanks.
By the way, don't understand the meaning of
bus, should we change it to a more understandable word
I'm also very confused about this,can you tell me what he wants to say？
By the way, don't understand the meaning of
bus, should we change it to a more understandable wordI'm also very confused about this,can you tell me what he wants to say？
I also don't know what this means, may need to consult other more senior maintainers
i find https://github.com/volcano-sh/apis/blob/master/pkg/apis/helpers/helpers.go this file in this project,most of them are ways to operate basic resource in k8s,it seems more reasonable to move this file to volcan.sh/volcano
@lucming, It's great to have this pr to upgrade api version. Thank you so much. We want to see the PR of v1 support in volcano repo prior to merging the api pr. Would you provide modification in volcano repo?
@lucming, It's great to have this pr to upgrade api version. Thank you so much. We want to see the PR of v1 support in volcano repo prior to merging the api pr. Would you provide modification in volcano repo?
I have written a version of the code to upgrade the volcano api version, but there are other things were delayed so have not mentioned pr.