Add default comment and defaulting logic for TaskSpec.MinAvailable
This PR adds a comment to TaskSpec.MinAvailable indicating it defaults to the task's Replicas, and implements a Default() method to set MinAvailable to Replicas if unset.
Welcome @SuyashParmar!
It looks like this is your first PR to volcano-sh/apis.
Thank you, and welcome to Volcano. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Please also execute bash ./hack/update-codegen.sh.
Please also execute
bash ./hack/update-codegen.sh.
done, ran successfully
Please also execute
bash ./hack/update-codegen.sh.done, ran successfully
And there is no CRD definition changed, so seems the default value will not be set automatically.