apis icon indicating copy to clipboard operation
apis copied to clipboard

Add default comment and defaulting logic for TaskSpec.MinAvailable

Open SuyashParmar opened this issue 7 months ago • 5 comments

This PR adds a comment to TaskSpec.MinAvailable indicating it defaults to the task's Replicas, and implements a Default() method to set MinAvailable to Replicas if unset.

SuyashParmar avatar Jul 22 '25 19:07 SuyashParmar

Welcome @SuyashParmar!

It looks like this is your first PR to volcano-sh/apis.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Jul 22 '25 19:07 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jul 22 '25 19:07 volcano-sh-bot

Please also execute bash ./hack/update-codegen.sh.

Monokaix avatar Jul 23 '25 08:07 Monokaix

Please also execute bash ./hack/update-codegen.sh.

done, ran successfully

SuyashParmar avatar Jul 23 '25 11:07 SuyashParmar

Please also execute bash ./hack/update-codegen.sh.

done, ran successfully

And there is no CRD definition changed, so seems the default value will not be set automatically.

Monokaix avatar Jul 26 '25 06:07 Monokaix