apis feat: add maxRetry option

ref: https://github.com/volcano-sh/volcano/pull/3846

Nov 29 '24 03:11 dongjiang1989

It doesn't look good. How about just adding a maxRetry field?

Dec 02 '24 02:12 hwdef

type Flow struct {
	// +kubebuilder:validation:MinLength=1
	// +required
	Name string `json:"name"`
	// +optional
	DependsOn *DependsOn `json:"dependsOn,omitempty"`
	// +optional
	MaxRetry *MaxRetry `json:"maxRetry,omitempty"`
}

Dec 02 '24 02:12 hwdef

It doesn't look good. How about just adding a maxRetry field?

Thanks @hwdef @googs1025 Got it. Just add maxRetry field done.

Dec 03 '24 07:12 dongjiang1989

@googs1025 Please re-check it

Feb 18 '25 06:02 dongjiang1989

feel free to go ahead. small suggestion: I like to fully express the meaning of this field on the field, just like the API docs maintained in k/k, which make it easier for users to understand the meaning of each field.

Feb 18 '25 06:02 googs1025

@hwdef @Monokaix @JesseStutler /PTAL

Feb 18 '25 07:02 googs1025

/lgtm

Feb 24 '25 08:02 hwdef

cc @googs1025 @Monokaix Please re-check it

Feb 25 '25 03:02 dongjiang1989

@Monokaix Please review it. Thanks Similar to this PR, when a CRD field changes, how to depend on it in volcano and submit a volcano PR?

Mar 18 '25 06:03 dongjiang1989

feel free to go ahead. small suggestion: I like to fully express the meaning of this field on the field, just like the API docs maintained in k/k, which make it easier for users to understand the meaning of each field.

Yeah I agree, comments should be added, and will this value be passed to the maxretry of vcjob?

Mar 19 '25 10:03 Monokaix

feel free to go ahead. small suggestion: I like to fully express the meaning of this field on the field, just like the API docs maintained in k/k, which make it easier for users to understand the meaning of each field.

Yeah I agree, comments should be added, and will this value be passed to the maxretry of vcjob?

Yeah. Pass this value to the maxretry of vcjob, replace the default value in jobTemplate

Mar 20 '25 01:03 dongjiang1989

New changes are detected. LGTM label has been removed.

Mar 20 '25 03:03 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign wpeng102 You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Oct 21 '25 02:10 volcano-sh-bot