apis icon indicating copy to clipboard operation
apis copied to clipboard

Add new state SchGated

Open ykcai-daniel opened this issue 1 year ago • 1 comments

To support Pod Scheduling Readiness, we need to add new state to api. For more detail, see proposal https://github.com/volcano-sh/volcano/pull/3581

ykcai-daniel avatar Jul 12 '24 09:07 ykcai-daniel

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign william-wang You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jul 12 '24 09:07 volcano-sh-bot

Previously, we introduced a new state to decouple scheduling gated jobs from inqueued jobs and ensure correct computation of inqueued resources without modifying plugins.

We have changed the design of pod scheduling gates. Since the main motivation is to ensure compatibility with K8S, we want to minimize change to existing api and implementations, therefore we no longer make change to the states in scheduler. Instead, we make changes to the plugins to make sure the inqueued resource is calculated correctly when there are scheduling gated tasks. More details in https://github.com/volcano-sh/volcano/pull/3658.

ykcai-daniel avatar Sep 06 '24 03:09 ykcai-daniel

That's a good idea!

Monokaix avatar Sep 10 '24 02:09 Monokaix

/close

Monokaix avatar Sep 10 '24 02:09 Monokaix

@Monokaix: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Sep 10 '24 02:09 volcano-sh-bot