apis icon indicating copy to clipboard operation
apis copied to clipboard

Published 20 hours ago • verified publisher icon volcano-sh

fix: close stopCh when recv signal

Open rfyiamcool opened this issue 2 years ago • 2 comments

change

when recive signal, if don't close stopCh, call klog.Fatalf, if close(stopCh), call klog.Info.

image

rfyiamcool avatar Jun 20 '23 08:06 rfyiamcool

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign william-wang after the PR has been reviewed. You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jun 20 '23 08:06 volcano-sh-bot

Welcome @rfyiamcool! It looks like this is your first PR to volcano-sh/apis 🎉

volcano-sh-bot avatar Jun 20 '23 08:06 volcano-sh-bot