volatility3 icon indicating copy to clipboard operation
volatility3 copied to clipboard

Remove comment of find library for windows if needed

Open j-t-1 opened this issue 11 months ago • 4 comments

The Windows library has previously been added to the try block.

j-t-1 avatar Jan 03 '25 16:01 j-t-1

I don't know that this works under windows, I haven't tried it? The FIXME is there to get me to check it? If you've checked that it works under windows, then I'll take it out happily, but otherwise we need to check it at somepoint (and having a FIXME there is a useful reminder).

ikelos avatar Jan 05 '25 20:01 ikelos

Have not run this under Windows. Was thinking (probably wrongly) that the comment was referring to lines 37 and 43. I think the comment could be changed to make it more self-explanatory.

j-t-1 avatar Jan 05 '25 21:01 j-t-1

No, you're right, those are the lines it's referring to, I just... never actually tested them. 5:P As soon as someone's confirmed that they've checked it all works right on windows, I'm happy to ditch the FIXME... 5:D

ikelos avatar Jan 05 '25 21:01 ikelos

No, you're right, those are the lines it's referring to, I just... never actually tested them. 5:P As soon as someone's confirmed that they've checked it all works right on windows, I'm happy to ditch the FIXME... 5:D

Installing python-snappy 0.7.3 on Windows and then trying ctypes.cdll.LoadLibrary("snappy32") and ctypes.cdll.LoadLibrary("snappy64") both give FileNotFoundError. On PyPI, the operating systems supported are MacOS and POSIX. This partially explains the TODO.

So for Snappy to work on Windows you need to compile from source, although I have not tested this.

j-t-1 avatar Oct 04 '25 12:10 j-t-1