Strange behaviour if user recover the account before the confirmation

[kenng]

After registration and before confirming the account, if the user recover the account via the link, the user will be auto log in, this is alright. If the user log out now, and try to login again he will be prompted to confirm his account again. So, probably we can consider the user account is confirmed if he is able to recover it?

[aarondl]

I think this makes sense. Because confirming and recovering both use the e-mail. Were you looking for us to fix this? Or were you going to submit a PR?

[aarondl]

It could be a little bit strange though looking at the code. It sort of violates the isolation we've got between the storage and the modules. Currently you can use one without the other, but this almost creates a dependency.

[kenng]

Haven't got the time to dive deep into the code, but what i remembered seeing there is a module function which will load each modules one by one. During the module registration, is there any possibility to register a callback function based on event? Then recover module can publish the event for confirm module to handle?

[aarondl]

Then it would depend on which module was loaded first unfortunately. :(

[aarondl]

Looking at this again, it's possible now in the v2 code to implement this properly using events. Ordering should not be a concern.