Vojtech Trefny

Results 138 comments of Vojtech Trefny

We are currently using filesystem tools to set label (for example `xfs_admin` for XFS) so I'd expect these tools to support online label change using this ioctl. Unfortunately this is...

I plan to take a look at this, but probably not as a part of #621, it could be a separate change.

Unfortunately blivet doesn't provide progress for the resize operation itself so I can't show the progress in the GUI, but I'll try to think of some way how to indicate...

I think we should allow passing `NULL` instead of error for our functions. It sometimes wouldn't make a lot of sense but it would definitely be easier and safer for...

So we now have two options: 1. Force our users to always provide us non-`NULL` GError. That's basically what we do right now, but is a little problematic because some...

These should be all functions with the error "problem". And it actually isn't that bad. `bd_fs_can_resize/check/repair...` -- false with error means "filesystem xyz not supported" so it just adds a...

> > So this leaves us with seven "problematic" functions: > `bd_fs_is_mountpoint` > `bd_crypto_device_is_luks` > `bd_crypto_device_seems_encrypted` > `bd_swap_swapstatus` > `bd_loop_get_autoclear` > `bd_dm_map_exists` > `bd_mpath_is_mpath_member` All functions should be now "safe"...

Ok, so the final decision is to do nothing. We can revisit this before the 3.0 release, but I think this is probably the best option.

I've removed the `blivet-gui_event.conf` installation in #353, the config file is kinda Fedora-specific thing and it doesn't really make sense to have it in handled by `setup.py`. As for the...

> If that file is needed IMO it would be good to leave it in git repo to be able use it during packaging process. I didn't remove the file...