voila
voila copied to clipboard
fix: ignore updates that happen before the full state is send
This can happen when the kernel is updating a widget from a thread at the same time as when we are requesting the states.
When this happens, we get an update without the full widget state, which causes the widget creation fo fail (since model and module are all undefined)
Note that this does not affect the new faster way, so ipywidgets 8 should not be affected by this bug.
Benchmark report
The execution time (in milliseconds) are grouped by test file, test type and browser. For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.
Results table
Test file | voila-tree-classic.ipynb | voila-tree-light.ipynb | voila-tree-dark.ipynb | voila-tree-miami.ipynb | basics.ipynb | bqplot.ipynb | dashboard.ipynb | gridspecLayout.ipynb | interactive.ipynb | ipympl.ipynb | ipyvolume.ipynb | multiple_widgets.ipynb | query-strings.ipynb | reveal.ipynb |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Render | ||||||||||||||
chromium |
||||||||||||||
actual | 115 <- [131 - 153 - 194] -> 333 | 80 <- [83 - 90 - 105] -> 134 | 71 <- [74 - 81 - 92] -> 112 | 68 <- [71 - 74 - 86] -> 109 | 2798 <- [2851 - 2924 - 3060] -> 4016 | 2678 <- [2689 - 2734 - 2760] -> 3160 | 3034 <- [3037 - 3040 - 3052] -> 3428 | 3848 <- [3893 - 3921 - 4039] -> 4219 | 2267 <- [2284 - 2312 - 2470] -> 2655 | 4288 <- [4321 - 4330 - 4549] -> 5097 | 8266 <- [11497 - 11526 - 11779] -> 12079 | 12792 <- [13045 - 13439 - 14362] -> 16635 | 1535 <- [1581 - 1589 - 1632] -> 1639 | 2714 <- [2741 - 2790 - 2910] -> 3020 |
expected | 3379 <- [3442 - 3517 - 3701] -> 3876 | 2976 <- [3227 - 3321 - 3421] -> 3604 | 3608 <- [3623 - 3709 - 3793] -> 3825 | 4453 <- [4453 - 4523 - 4661] -> 4748 | 2559 <- [2655 - 2656 - 2660] -> 2674 | 3982 <- [4079 - 4213 - 4356] -> 4743 | 12183 <- [18509 - 19553 - 20811] -> 21515 | 15319 <- [15660 - 15796 - 15912] -> 16056 | 1517 <- [1920 - 1997 - 2103] -> 2113 |
:exclamation: Test metadata have changed
--- /dev/fd/63 2022-02-24 09:08:22.704339091 +0000
+++ /dev/fd/62 2022-02-24 09:08:22.704339091 +0000
@@ -4,37 +4,37 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® Platinum 8171M",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
- "l2": 2097152,
- "l3": 36700160
+ "l2": 524288,
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "85",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.6,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "4",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7284850688
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.11.0-1028-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "b77b4ec5b44b40a7913d0d5091bccfef",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
}