__________

Results 11 comments of __________

This should probably be closed @johanhelsing

How is this coming along? I have found that the fork consistently throws segfaults when used with OpenGl when creating RenderContext on Windows 10 using mpv-dev-x86_64-1.109. I have tried out...

Btw, debugging tells me that that segfault happens in gpa_wrapper when calling params.get_proc_address, whose pointer is 0xabababababababab. When RenderContext::new is called, the structure is still valid. `params[1].0.get_proc_address` is `48 81...

See: ``` impl From for mpv_opengl_init_params { fn from(val: OpenGLInitParams) -> Self { Self { // vvv Callsite vvv get_proc_address: Some(gpa_wrapper::), get_proc_address_ctx: Box::into_raw(Box::new(val)) as *mut c_void, extra_exts: ptr::null(), } }...

Fixed version: ``` impl From for mpv_opengl_init_params { fn from(val: OpenGLInitParams) -> Self { Self { get_proc_address: Some(gpa_wrapper::), get_proc_address_ctx: Box::into_raw(Box::new(val)) as *mut c_void, extra_exts: ptr::null(), } } } unsafe extern...

- Make sure you have the most recent Visual Studio installed (see https://github.com/mpv-player/mpv/blob/master/DOCS/compile-windows.md#linking-libmpv-with-msvc-programs saying that it must support `stdint.h` - You can download the libmpv stuff from https://sourceforge.net/projects/mpv-player-windows/files/libmpv/, or build...

Yes, so, this seems to be a bug in the LuaBlock parser? I got around it by adding the recipe directly via the respective API: ``` Item canisterItem = GameRegistry.findItem("TConstruct",...

As for panning, see the member `pan_zoom` of `GraphEditorState`. Unlike the name suggests, though, zoom does not seem to be supported natively: https://github.com/setzer22/egui_node_graph/issues/53

I've made a little non-intrusive PR for supporting serialization of metadata, see https://github.com/ron-rs/ron/pull/544

Or, instead of a structural change, simply add a bulk of non-audio codec types? ```rs pub(crate) fn codec_id_to_type(track: &TrackElement) -> Option { // .. match track.codec_id.as_str() { "V_AV1" => Some(codecs::CODEC_TYPE_AV1),...