void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

flameshot: update to 13.0.1

Open elbachir-one opened this issue 4 months ago • 3 comments

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (ARCH-LIBC)

elbachir-one avatar Aug 11 '25 20:08 elbachir-one

Can you add configure_args="-DENABLE_IMGUR=ON", as image upload was moved behind a compile option in this release.

dmarto avatar Aug 12 '25 18:08 dmarto

Build issues:

  • KDSingleApplication conflict: should just disable it with -DUSE_KDSINGLEAPPLICATION=OFF
  • Cross building failure: add qt6-base to hostmakedepends

Additionally:

  • It's not good practice to allow build systems fetch whatever it wants with git
  • Might be worthwhile to create build option for imgur feature, mirroring upstream

My attempt:

# Template file for 'flameshot'
pkgname=flameshot
version=13.1.0
revision=1
_qt_color_widgets_version=3.0.0
build_style=cmake
configure_args="-DDISABLE_UPDATE_CHECKER=ON -DUSE_KDSINGLEAPPLICATION=OFF
 $(vopt_if imgur -DENABLE_IMGUR=ON)"
hostmakedepends="qt6-tools qt6-base"
makedepends="qt6-svg-devel qt6-wayland-devel"
depends="$(vopt_if imgur qt6-plugin-tls-openssl)"
short_desc="Powerful yet simple to use screenshot software for GNU/Linux"
maintainer="Orphaned <[email protected]>"
license="GPL-3.0-or-later"
homepage="https://github.com/lupoDharkael/flameshot"
distfiles="https://github.com/lupoDharkael/flameshot/archive/v${version}.tar.gz
 https://gitlab.com/mattbas/Qt-Color-Widgets/-/archive/${_qt_color_widgets_version}/Qt-Color-Widgets-${_qt_color_widgets_version}.tar.gz>Qt-Color-Widgets.tar.gz"
checksum="1d755a618bdcb3e739f691cea55ed2d432f93e521a504f95b74abed0c595f6f7
 8b8020d661894ece5bfb96d0b4e2e0e15db69839a986b59f8748f12c603e021b"
skip_extraction="Qt-Color-Widgets.tar.gz"

build_options="imgur"
desc_option_imgur="Enable uploading screenshot to Imgur online service"

post_extract() {
	vsrcextract -C external/Qt-Color-Widgets/ --strip-components=1 Qt-Color-Widgets.tar.gz
}

Note: I am assuming qt6-wayland-devel is needed on Wayland; I can't test it on my X11 system where I didn't need it to build/use flameshot.

natrys avatar Sep 09 '25 16:09 natrys

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Dec 09 '25 02:12 github-actions[bot]