void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

polychromatic: Add missing dependency

Open northboot opened this issue 1 year ago • 2 comments

Problem: polychromatic-controller misses a dependency:

Traceback (most recent call last):
  File "/usr/bin/polychromatic-controller", line 36, in <module>
    import polychromatic.controller as controller
  File "/usr/lib/python3.12/site-packages/polychromatic/controller/__init__.py", line 1, in <module>
    from . import devices, effects, menubar, preferences, shared
  File "/usr/lib/python3.12/site-packages/polychromatic/controller/devices.py", line 27, in <module>
    from . import shared
  File "/usr/lib/python3.12/site-packages/polychromatic/controller/shared.py", line 17, in <module>
    from PyQt6.QtSvg import QSvgRenderer
ModuleNotFoundError: No module named 'PyQt6.QtSvg'

This adds the missing dependency which is requred for polychromatic-controller to work.

  • I tested the changes in this PR: briefly

northboot avatar Oct 20 '24 19:10 northboot

Can you also bump it to 0.9.2, now that OpenRazer 3.9 is merged.

(I personally still run the Qt5 version, and haven't had the time to deal with the Qt6 port)

dmarto avatar Oct 21 '24 11:10 dmarto

Can you also bump it to 0.9.2, now that OpenRazer 3.9 is merged.

(I personally still run the Qt5 version, and haven't had the time to deal with the Qt6 port)

Done in 506c64b5e1268857c748eaaacefc2118c05ceace.

northboot avatar Oct 21 '24 18:10 northboot

squash this into 1 commit

classabbyamp avatar Oct 26 '24 17:10 classabbyamp

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Jan 25 '25 01:01 github-actions[bot]

Did upgrade to a new maintenance release.

northboot avatar Feb 08 '25 01:02 northboot

please rebase to fix the conflict

classabbyamp avatar Feb 08 '25 04:02 classabbyamp

that's a merge, not a rebase. you're not going to be able to do it on github, you need to do it locally.

classabbyamp avatar Feb 08 '25 22:02 classabbyamp

Hope it is ok now, not sure why I had to solve merge conflicts this time as opposed to last time

northboot avatar Feb 08 '25 22:02 northboot