void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

lsp-plugins: update to 1.2.19, enable cross build.

Open Calandracas606 opened this issue 1 year ago • 8 comments

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • i686
    • aarch64 (cross)
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv7l-musl (cross)
    • armv6l (cross)
    • armv6l-musl (cross)

patch submitted upstream: https://github.com/lsp-plugins/lsp-common-lib/pull/1

Also relevant for: https://github.com/void-linux/void-packages/pull/39796

Calandracas606 avatar Oct 14 '24 20:10 Calandracas606

Not sure why, but this seems to break wireplumber for me (gets stuck at 100% CPU). Downgrading the package fixes it, so marking as draft until I can figure out what's going on

Calandracas606 avatar Oct 16 '24 22:10 Calandracas606

let me also try and report. I wonder if it's musl-related.

dkwo avatar Oct 17 '24 13:10 dkwo

@Calandracas606 In the meantime, do you mind comparing the content of xls lsp-plugins-lv2 before and after, and only testing with that pkg installed?

dkwo avatar Oct 17 '24 14:10 dkwo

the only differences are some extra files in the newer package:

chorus_mono.ttl
chorus_stereo.ttl
return_mono.ttl
return_stereo.ttl
send_mono.ttl
send_stereo.ttl

Calandracas606 avatar Oct 17 '24 15:10 Calandracas606

same for me on glibc

dkwo avatar Oct 19 '24 20:10 dkwo

(btw, those diffs exist in CI or with xpkgdiff -f)

classabbyamp avatar Oct 19 '24 20:10 classabbyamp

Sure. I meant that this breaks wireplumber for me too.

dkwo avatar Oct 19 '24 22:10 dkwo

Btw, even just the simple update (without the patch and configure change) breaks wireplumber for me, so this may be an upstream bug.

dkwo avatar Oct 20 '24 18:10 dkwo

Looking at my dinit user service for wireplumber, the only difference in logs between the two versions is that the bad one has W 10:22:54.439190 mod.filter-chain ../src/modules/module-filter-chain.c:1929:parse_control: control 'cbe_0' can not be set: No such file or directory but it misses W 10:34:09.023572 m-lua-scripting asahi-limit-volume.lua:43:chunk: <WpSpaPod:0xaaab992c7860> Forcing Speaker route props: <WpDev. Ref to upstream asahi issue: https://github.com/AsahiLinux/asahi-audio/issues/48

dkwo avatar Nov 09 '24 15:11 dkwo

Bug with aarch64 has been fixed upstream, added patch to this PR.

Should be good to go

Calandracas606 avatar Nov 11 '24 22:11 Calandracas606

I tried to install lsp for aarch64 from the repo, but it's not yet available. @classabbyamp Do you mind checking that the builders are rsyncing correctly?

dkwo avatar Nov 13 '24 14:11 dkwo

https://build.voidlinux.org/#/changes/1143

classabbyamp avatar Nov 13 '24 21:11 classabbyamp