void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard
verified publisher icon void-linux

elvish: update to 0.21.0.

Open jwldr opened this issue 1 year ago • 2 comments

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

jwldr avatar Oct 03 '24 08:10 jwldr

When running ./xbps-src check elvish the same tests fail as in the CI pipeline.

But running go test ./... locally in the elvish repository succeeds.

jwldr avatar Oct 03 '24 10:10 jwldr

Turns out these unit tests have been enabled with go build style just two months ago (with 332756ed0859dd6a1d2c45532642e1bc55f908c4). Before that commit they have never been executed with this template.

I locally ran xbps-src check elvish with enabled unit tests in previous versions like 0.20.1 (2a2940e317d99b2e3c9505e936b6ad80d5e5a2a1) and the same tests are failing. Therefore, I suspect that this problem has not been noticed until now because the tests were deactivated.

I suggest disabling the tests temporarily until a solution to the issue is found (as mentioned the test fail only when run via xbps-src.

jwldr avatar Oct 06 '24 16:10 jwldr

@classabbyamp is anything missing?

jwldr avatar Oct 25 '24 07:10 jwldr