void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

Sile update to 0.15.4

Open Luciogi opened this issue 1 year ago • 2 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86-GLIBC)

Note:

  • lua54-toolkit does not provide license file

Luciogi avatar Jul 12 '24 13:07 Luciogi

  • [x] fix licenses
  • [x] remove redundancy from sile

Luciogi avatar Jul 13 '24 08:07 Luciogi

My knowledge of Void is limited, but I'm deeply familiar with Arch Linux packaging which is relatively similar, and as the upstream maintainer for SILE I can say this all looks pretty copacetic.

alerque avatar Aug 30 '24 20:08 alerque

@alerque Hi, I am building 0.15.6 for cross archs

i am getting error about rusile.so, but it is not present at rust binary output directory, instead there is librusile.so

image

Luciogi avatar Nov 25 '24 17:11 Luciogi

i am getting error about rusile.so, but it is not present at rust binary output directory, instead there is librusile.so

The original code is installing target/release/librusile.so -> rusile.so. Your monkey patch for the cross compile thing is screwing that up because your are catching this new line instead of the original you intended to match.

rusile.so: $(rusile_so_SOURCES) $(bin_PROGRAMS)
	$(CARGO_ENV) $(CARGO) build $(CARGO_VERBOSE) --target $(CARGO_TARGET_TRIPLE) $(RUSILE_FEATURE_ARG) $(CARGO_RELEASE_ARGS) -p rusile
$(INSTALL) @builddir@/target/@RUST_TARGET_SUBDIR@/lib$@ $@

alerque avatar Nov 25 '24 20:11 alerque

i am getting error about rusile.so, but it is not present at rust binary output directory, instead there is librusile.so

The original code is installing target/release/librusile.so -> rusile.so. Your monkey patch for the cross compile thing is screwing that up because your are catching this new line instead of the original you intended to match.

rusile.so: $(rusile_so_SOURCES) $(bin_PROGRAMS)
	$(CARGO_ENV) $(CARGO) build $(CARGO_VERBOSE) --target $(CARGO_TARGET_TRIPLE) $(RUSILE_FEATURE_ARG) $(CARGO_RELEASE_ARGS) -p rusile
$(INSTALL) @builddir@/target/@RUST_TARGET_SUBDIR@/lib$@ $@

After adding upstream patch, removing hacks, now sile got to linking error https://github.com/void-linux/void-packages/actions/runs/12026998189/job/33527112308?pr=51222#step:7:4168

Luciogi avatar Nov 26 '24 08:11 Luciogi

I see where you added the patch to the repository but I do not see where it is being applied. Is that automatic just by the patch existing? Or did it not actually get applied?

alerque avatar Nov 26 '24 09:11 alerque

I see where you added the patch to the repository but I do not see where it is being applied. Is that automatic just by the patch existing? Or did it not actually get applied?

patches are applied automatically, before configure function runs

edit: it can be seen here https://github.com/void-linux/void-packages/actions/runs/12026998189/job/33527112308?pr=51222#step:7:3163

Luciogi avatar Nov 26 '24 09:11 Luciogi

I just released SILE v0.15.7 with this patch baked in, so you can drop the patch and not worry about having to run autoreconf. Ping me if that still has any trouble building and I'll look into it.

alerque avatar Nov 26 '24 14:11 alerque

Hey @Johnnynator sorry for the intrusion but would you by any chance be able to review this? I've seen you bump the sile package on Void before but it has since fallen very out of date including a number of dependency changes over the years.

This PR has been a long time in the works but it seems (to me on the outside) to have been working properly across several upstream release cycles now. If there is something amiss that is blocking this moving on I'm sure both the OP and I would be happy to step in and address it.

alerque avatar Nov 27 '24 07:11 alerque

@Luciogi thx for taking care of this package

@alerque Sry that I did not update the package over the years, I have kinda not used sile since I packaged it 6 years ago, I suppose it changed quite a bit since then. Maybe I will have a reason to look at it again in the future.

Johnnynator avatar Jan 02 '25 00:01 Johnnynator

@Luciogi thx for taking care of this package

@alerque Sry that I did not update the package over the years, I have kinda not used sile since I packaged it 6 years ago, I suppose it changed quite a bit since then. Maybe I will have a reason to look at it again in the future.

Thanks to you from looking to this PR

Luciogi avatar Jan 02 '25 08:01 Luciogi