void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: fnm-1.35.1

Open heppu opened this issue 1 year ago • 3 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture: x86_64
  • I built this PR locally for these architectures:
    • x86_64-musl
    • aarch64
    • aarch64-musl
    • armv6hf-musl
    • armv6hf
    • armv6l-musl
    • armv6l
    • armv7hf-musl
    • armv7hf
    • armv7l-musl
    • armv7l

heppu avatar Apr 05 '24 12:04 heppu

@classabbyamp Fixed the linting errors.

heppu avatar Apr 07 '24 11:04 heppu

please don't ping me on PRs I'm not already involved in

classabbyamp avatar Apr 07 '24 11:04 classabbyamp

Oh, I'm sorry. I thought it was you who allowed the workflow to be executed.

heppu avatar Apr 07 '24 14:04 heppu

Are you still working on this? fnm before 1.36.0 does not really work on musl (due to hardcoded arch check, I made a PR to mitigate that in 1.36.0) although it does build. And it's no point to build for musl other than x86_64 as unofficial node mirror only has x64-musl tarballs.

Vinfall avatar Jul 03 '24 03:07 Vinfall

You may find this patch useful:

--- template	2024-07-03 04:20:29.000000000 +0000
+++ template	2024-07-03 04:19:26.000000000 +0000
@@ -1,18 +1,19 @@
 # Template file for 'fnm'
 pkgname=fnm
-version=1.35.1
+version=1.37.1
 revision=1
+archs="x86_64-musl ~*-musl"
 build_style=cargo
 build_helper=qemu
 hostmakedepends="pkg-config"
 makedepends="libzstd-devel"
 short_desc="Fast and simple Node.js version manager, built in Rust"
 maintainer="Henri Koski <[email protected]>"
-license="GPL-3.0-or-later"
+license="GPL-3.0-only"
 homepage="https://github.com/Schniz/fnm"
 changelog="https://raw.githubusercontent.com/Schniz/fnm/master/CHANGELOG.md"
 distfiles="https://github.com/Schniz/fnm/archive/refs/tags/v${version}.tar.gz"
-checksum=df0f010f20e6072a8a52365f195cc94c35ebaf486cc285948e10eabf768d17ba
+checksum=56a170304ab281439a71e541c4db878848c3a891078ae3c2dcc84017cd0306b4
 
 post_install() {
 	for shell in bash fish zsh; do

I'm not very sure whether node.js has builds for all those archs. You may also need to expose a few environment variables as I said in https://github.com/Schniz/fnm/issues/694#issuecomment-2049004644 or patch them during build time for musl (but I have no idea if xbps can do that, i.e. run patch only on musl builds).

Vinfall avatar Jul 03 '24 04:07 Vinfall

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Oct 02 '24 01:10 github-actions[bot]