void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: iamb-0.0.10

Open Bnyro opened this issue 1 year ago • 5 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

closes #49586

Bnyro avatar Apr 01 '24 14:04 Bnyro

Tested on x86_64-glibc, joined a room and sent a message. Works as expected!

AnInternetTroll avatar Apr 07 '24 15:04 AnInternetTroll

Super duper nitpick, but the manpage is technically wrong on void https://github.com/ulyssa/iamb/blob/e5b284ed19cb99f79a0cbaca9e2339b9171e6d6d/docs/iamb.5#L541C1-L543C43

.Sy iamb
will load if the TOML one is not found.
.It Pa /usr/share/iamb/config.example.toml
A sample configuration file with examples of how to set different values.
.El

Should actually be /usr/share/examples/iamb/config.example.toml, with an added examples/

AnInternetTroll avatar Apr 07 '24 17:04 AnInternetTroll

Tested it again with the lib changes and it still works

AnInternetTroll avatar Apr 07 '24 17:04 AnInternetTroll

I guess we should report the test failure om i686 upstream?

Bnyro avatar Apr 07 '24 18:04 Bnyro

I guess we should report the test failure om i686 upstream?

I've let them know on matrix that the one test is failing on 32bit (I assume it would fail on armv* as well if the CI would run those tests)

--

About my earlier comment on the manpage, what I meant to say is that maybe the manpage should be vsed'd to change that one line. Something like this for example

vsed -i docs/iamb.5 -e 's#/usr/share/iamb/config.example.toml#/usr/share/examples/iamb/config.example.toml#'

You should still vsconf the file though, that part was correct

AnInternetTroll avatar Apr 07 '24 20:04 AnInternetTroll

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Nov 27 '24 02:11 github-actions[bot]

bump

Bnyro avatar Nov 27 '24 10:11 Bnyro

I think this can be merged. The client works as expected, is in current version and has been tested on multiple arch/libc-implementations. My testing with x86_64-glibc was successful as well. I love it!

Anachron avatar Jan 09 '25 20:01 Anachron