void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

gnome: update to 46.0.

Open fanyx opened this issue 11 months ago • 41 comments

Missing for gnome-core

  • [x] gnome-control-center
  • [x] https://github.com/void-linux/void-packages/pull/49427
  • [x] https://github.com/void-linux/void-packages/pull/49446
  • [x] https://github.com/void-linux/void-packages/pull/49473
  • [x] https://github.com/void-linux/void-packages/pull/49482
  • [x] gjs>=1.80.0
  • [x] https://github.com/void-linux/void-packages/pull/49895

Missing for gnome

  • [ ] gnome-remote-desktop-46.1
    • [ ] https://github.com/void-linux/void-packages/pull/49982
    • [ ] https://github.com/void-linux/void-packages/pull/49985
    • [ ] polkit>=122
  • [x] https://github.com/void-linux/void-packages/pull/49940
  • [x] https://github.com/void-linux/void-packages/pull/49941
  • [x] https://github.com/void-linux/void-packages/pull/49918
  • [ ] https://github.com/void-linux/void-packages/pull/49945
  • [x] https://github.com/void-linux/void-packages/pull/49947
  • [ ] https://github.com/void-linux/void-packages/pull/49946
  • [ ] https://github.com/void-linux/void-packages/pull/49957
  • [x] https://github.com/void-linux/void-packages/pull/49913
  • [x] https://github.com/void-linux/void-packages/pull/49916
  • [x] https://github.com/void-linux/void-packages/pull/49639

@oreo639 @Gottox

TODO

  • [x] Update glib and glib-networking dependencies to 2.80.0

Testing the changes

  • I tested the changes in this PR:
    • gnome-core: YES
    • gnome: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

fanyx avatar Mar 21 '24 14:03 fanyx

gnome-control-center (no 46.0 release yet, changelog)

The 46.0 release changelog is in the gnome-46 branch: https://gitlab.gnome.org/GNOME/gnome-control-center/-/raw/gnome-46/NEWS The 46.0 release is also here: https://download.gnome.org/sources/gnome-control-center/46/

oreo639 avatar Mar 21 '24 17:03 oreo639

oh, nice find main branch is still stuck on 46.rc

added

fanyx avatar Mar 21 '24 17:03 fanyx

https://gitlab.gnome.org/GNOME/gdm/-/commit/2da9b953e3c3931f59d2e312f2deba10ca628146 merged yesterday, not yet in builds though

fanyx avatar Mar 22 '24 12:03 fanyx

https://gitlab.gnome.org/GNOME/gdm/-/commit/2da9b953e3c3931f59d2e312f2deba10ca628146 merged yesterday, not yet in builds though

Just add .patch to the end of the url and you can import the patch.

oreo639 avatar Mar 22 '24 21:03 oreo639

removed tracker and tracker-miners tracked in #49473

fanyx avatar Mar 23 '24 08:03 fanyx

On gnome-core 45.5, a bug was noticed with the display of qt windows and wine windows (something else?). qt windows do not change size by hovering the cursor over the edge as usual. Wine too, while the cursor inside the window may stop interacting with the window itself (as if it went beyond the boundaries) The problem exists on wayland and xorg only at the first login, if you relogin, the problem disappears. I have now compiled gnome-core 46.0 from your sources and the problem persists. Before that, I collected 45.4 locally, there was no problem (I am writing through a translator, there may be a misunderstanding)

Jaymz665 avatar Mar 26 '24 13:03 Jaymz665

@Jaymz665 Downgrade to gtk4-4.12.5, and see if the problem disappears. It did for me. gtk4-4.14.1 is buggy, imo.

Use the patch below:

--- b/srcpkgs/gtk4/template
+++ a/srcpkgs/gtk4/template
@@ -1,6 +1,6 @@
 # Template file for 'gtk4'
 pkgname=gtk4
+version=4.12.5
-version=4.14.1
 revision=1
 build_style=meson
 build_helper="gir"
@@ -30,10 +30,10 @@
 maintainer="Orphaned <[email protected]>"
 license="LGPL-2.1-or-later"
 homepage="https://www.gtk.org/"
+# changelog="https://gitlab.gnome.org/GNOME/gtk/-/raw/main/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gtk/-/raw/gtk-4-12/NEWS"
-changelog="https://gitlab.gnome.org/GNOME/gtk/-/raw/main/NEWS"
-# changelog="https://gitlab.gnome.org/GNOME/gtk/-/raw/gtk-4-14/NEWS"
 distfiles="${GNOME_SITE}/gtk/${version%.*}/gtk-${version}.tar.xz"
+checksum=28b356d590ee68ef626e2ef9820b2dd21441484a9a042a5a3f0c40e9dfc4f4f8
-checksum=fcefb3f132f8cc4711a9efa5b353c9ae9bb5eeff0246fa74dbc2f2f839b9e308
 
 # Package build options
 build_options="broadway cloudproviders colord cups gir vulkan wayland x11 tracker"

P.S. I know nautilus-46.0 requires gtk4>=4.13.6, but works fine with 4.12.5

chrysos349 avatar Mar 26 '24 14:03 chrysos349

@Jaymz665 Can you make a separate issue for this, since this isn't related to this PR: https://github.com/void-linux/void-packages/issues/new?assignees=&labels=bug%2Cneeds-testing&projects=&template=bug-report.yml

Also, I can still reproduce it with gtk4 4.12.5.

oreo639 avatar Mar 28 '24 03:03 oreo639

@oreo639 yes, of course, but let's first find out exactly what the problem is, because on @chrysos349 advice, I rolled back to gtk4-4.12.5 and the problem disappeared (although the console stopped working). So I think we need to understand where the error lies. My local 45.4 had no errors, the current 45.5 and (honestly stolen templates) on 46.0 have it. So far, it really looks like gtk4, but since you reproduced the error, does it mean there is something else?

upd: I created issue, I'm not sure how well https://github.com/void-linux/void-packages/issues/49575

Jaymz665 avatar Mar 28 '24 06:03 Jaymz665

Updated glib, gvfs, gnome-online-accounts and tracker depends

fanyx avatar Apr 18 '24 08:04 fanyx

https://github.com/void-linux/void-packages/commit/71c04b6e5670a30710e6dbd96c70237e2f8c4044

guess i'll remove evolution-data-server from this, huh?

fanyx avatar Apr 18 '24 09:04 fanyx

Dropped evolution-data-server and gcc14.patch for xdg-desktop-portal-gnome

gnome-core now builds for me on x86_64-glibc

fanyx avatar Apr 18 '24 09:04 fanyx

Updates:

  • folks --> 0.15.9
  • gcr --> 3.41.2
  • gcr4 --> 4.3.0
  • gnome-control-center --> 46.0.1
  • gnome-online-accounts --> 3.50.1
  • libgweather --> 4.4.2
  • librsvg --> 2.58.0
  • libsecret --> 0.21.4
  • sushi --> 46.0
  • tecla --> 46.0

chrysos349 avatar Apr 18 '24 11:04 chrysos349

Feel free to submit prs for those, most of them can be updated seperately (except for gnome-control-center ofc)

oreo639 avatar Apr 18 '24 11:04 oreo639

i'll take on sushi as it kinda is part of gnome46 control-center will be part of this PR, might as well

the rest is probably best left to their own PR and mentioned here

fanyx avatar Apr 18 '24 11:04 fanyx

i'll take on sushi as it kinda is part of gnome46

sushi should be a separate PR. (it is just the file-preview in nautilus when you press the spacebar)

oreo639 avatar Apr 18 '24 12:04 oreo639

oh yeah, absolutely but i'll look into it as i want it ready for when we review this gnome-core PR as sort of a "gnome 46 release"

the rest can probably be updated separately

fanyx avatar Apr 18 '24 12:04 fanyx

Updated gnome-control-center and gnome-online-accounts

fanyx avatar Apr 18 '24 12:04 fanyx

@oreo639 ready for review imo

fanyx avatar Apr 19 '24 09:04 fanyx

Not yet. Also, remove ci skip and keep in mind gnome-online-accounts requires quite a few rebuilds that are not accounted for.

oreo639 avatar Apr 19 '24 09:04 oreo639

oh, yeah.. should i add those here?

fanyx avatar Apr 19 '24 09:04 fanyx

should i add those here?

~~If gnome-online-accounts can be updated separately, probably best to do it separately, but I'll check.~~

oreo639 avatar Apr 19 '24 09:04 oreo639

Nvm, it is just cinnamon-control-center that needs to be revbumped, and it needs -Donlineaccounts=false. (gnome-online-accounts cannot be updated seperately)

oreo639 avatar Apr 19 '24 09:04 oreo639

what about all the other revdeps of gnome-online-accounts?

fanyx avatar Apr 19 '24 09:04 fanyx

what about all the other revdeps of gnome-online-accounts?

xbps-query -Rs libgoa-backend-1.0.so -p shlib-requires

oreo639 avatar Apr 19 '24 09:04 oreo639

libgoa-1.0.so.0 is irrelevant?

fanyx avatar Apr 19 '24 09:04 fanyx

libgoa-1.0.so.0 is irrelevant?

Should be, the soversion didn't change so it should still be backwards compatible. The main change was that the sign-in widgets use gtk4 instead of webkitgtk.

oreo639 avatar Apr 19 '24 09:04 oreo639

gnome-tweaks

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 963940101..9954c5e7f 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -1,17 +1,19 @@
 # Template file for 'gnome-tweaks'
 pkgname=gnome-tweaks
-version=45.2
+version=46.0
 revision=1
 build_style=meson
-hostmakedepends="pkg-config gettext"
-makedepends="libhandy1-devel"
-depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
+build_helper=gir
+hostmakedepends="desktop-file-utils gettext gtk4-update-icon-cache pkg-config"
+makedepends="gsettings-desktop-schemas-devel libadwaita-devel
+ python3-gobject-devel"
+depends="dconf gnome-settings-daemon libadwaita mutter python3-gobject"
 short_desc="GNOME tool to customize advanced options"
 maintainer="Enno Boland <[email protected]>"
 license="GPL-3.0-or-later, CC0-1.0"
 homepage="https://wiki.gnome.org/Apps/Tweaks"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=01bf5e723a1d18b1025401e32b5f64eb29b79e8a17ad010bbbd1e23b137b9069
+checksum=1678786341f664ac4580784222a16409fa9bf5cc7a5f1b46dcefd2aa13ddba31
 replaces="gnome-tweak-tool>=0"
 
 gnome-tweak-tool_package() {

chrysos349 avatar Apr 19 '24 15:04 chrysos349

gnome-tweaks

that's part of gnome, not gnome-core? create a separate PR, always helps

fanyx avatar Apr 19 '24 15:04 fanyx

i know. gnome-tweaks needs gsettings-desktop-schemas>= 46.0. might as well add it here. let @oreo639 decide.

chrysos349 avatar Apr 19 '24 15:04 chrysos349