void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

gnome-connections: update to 45.0

Open chrysos349 opened this issue 1 year ago • 4 comments

split into a separate pr (https://github.com/void-linux/void-packages/pull/48762#issuecomment-1976502687).

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl x
    • armv7l x
    • armv6l-musl x

chrysos349 avatar Mar 05 '24 07:03 chrysos349

Hrm, I'm getting intermittent segfaults when trying to connect to localhost. I'll look in to it more later.

oreo639 avatar Mar 06 '24 04:03 oreo639

I enabled remote desktop on localhost via gnome-remote-desktop (#49123), and successfully connected to localhost with gnome-connections. No segfaulting.

** UPD 1** Actually, i reproduced the same intermittent segfaults when trying to connect to localhost. It happens when I copy an image to the clipboard.

../gdk/wayland/gdkselection-wayland.c:283: error reading selection buffer: Operation was cancelled
No data received from local clipboard for sending to remote side!

When I connect to the remote windows box, no segfaulting happens (even if I have an image in the clipboard).

Does it mean the bug is specific to localhost connections and has something to do with the clipboard contents? (Who needs connecting to the localhost anyway??)

UPD 2 here is what I found in release notes for gnome-connections-46.beta see here - https://download.gnome.org/sources/gnome-connections/46/gnome-connections-46.beta.news

- Update gtk-frdp
     - Fix several crashes related to clipboard channel

that may be the ~~reason~~ fix for the crashes.

chrysos349 avatar Mar 06 '24 05:03 chrysos349

The backported patch didn't fix crashes.

45.0 introduced clipboard channel support (via the update gtk-frdp widget), which causes crashes. 46.beta and 46.rc also crash.

44.0 doesn't exhibit this behavior, because it doesn't have clipboard channel.

AGAIN, the crash only happens with localhost connections. Remote connections don't crash, and I can successfully paste an image into the document on the windows box.

UPD 1 flatpak version of gnome-connections-45.0 crashes as well.

UPD 2 I filed a bug upstream (https://gitlab.gnome.org/GNOME/connections/-/issues/158)

chrysos349 avatar Mar 06 '24 08:03 chrysos349

gnome-connections-45.0 on Ubuntu 23.10 also crashes when having something in the clipboard and connecting to localhost. So not a void-specific bug.

chrysos349 avatar Mar 06 '24 13:03 chrysos349

connections-46.0 has been released any chance you want to look into building the newest version? idk what your progress has been here

fanyx avatar Apr 20 '24 13:04 fanyx