void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: auto-cpufreq-2.2.0

Open meator opened this issue 1 year ago • 3 comments

auto-cpufreq is doing some weeeeird stuff in auto_cpufreq/core.py. I will likely have to patch out a lot of things there.

Testing the changes

  • I tested the changes in this PR: YES

New package

meator avatar Feb 20 '24 20:02 meator

I am unsure whether the power-profiles-daemon detection mechanism in the runit service is acceptable, but everything else should be OK.

meator avatar Feb 20 '24 23:02 meator

I wouldn't guard it. I would just have a note in the README.voidlinux that the two conflict and should not be run at the same time.

abenson avatar Feb 21 '24 00:02 abenson

I wouldn't guard it. I would just have a note in the README.voidlinux that the two conflict and should not be run at the same time.

@abenson I don't think many people read or know about the README.voidlinux specific documentation. Having a safeguard, although a not "100%" one, could be useful. What do you think?

A proper safeguard would require adding the same check, but reverse, to power-profiles-daemon runit service. Doing that is intrusive, so I didn't do it. There might also be some other edge cases that I haven't thought of. Also this advanced usage of runit isn't really supported by runit well, it doesn't really have a built in way to have dependencies in services or have mutually exclusive services (which is required here) except sv shenanigans.

meator avatar Feb 21 '24 07:02 meator

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Aug 08 '24 01:08 github-actions[bot]