void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: ags-1.8.0

Open raitonoberu opened this issue 1 year ago • 6 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

I used to build it successfully using this template, but now it crashes during compilation of python3-3.12.1_1 as a Meson dependency, full log. UPD: fixed by merging upstream

raitonoberu avatar Jan 31 '24 18:01 raitonoberu

This package should be called ags.

ahesford avatar Jan 31 '24 19:01 ahesford

Sure, I'll fix it. This name was copied from the AUR and Copr packages.

  1. What should I do with a libgvc.so file conflict? (x86_64-glibc build)
  2. ARM builds fail with Program 'glib-mkenums' not found or not executable.

raitonoberu avatar Jan 31 '24 19:01 raitonoberu

Okay, cross-compilation is finally working. Now only the file conflict remains. From what I've learned, this project builds libgnome-volume-control, so graphviz-devel's libgvc.so is a completely different library.

How do we resolve it?

raitonoberu avatar Feb 02 '24 17:02 raitonoberu

I resolved this issue for the AUR package by specifying --libdir lib/ags option to meson, so libgvc.so is installed to /usr/lib/ags/libgvc.so instead of /usr/lib/libgvc.so.

I think you can achieve the same here by specifying it in the configure_args field.

Also passing -Dbuild_types=true option to meson will enable the generation of the types for the config. This is false by default and optional, but I enabled it in the aur package, because this is a feature most users want. So you might want yo consider enabling this by default here as well.

kotontrion avatar Feb 08 '24 21:02 kotontrion

Thank you very much @kotontrion! I missed that part of your script and wasn't experienced enough to fix it myself.

After building it locally, I noticed a broken symlink /usr/bin/ags, so I linked it manually, as you did. I'm sure v1.6.3 didn't need this, don't you know what caused this regression?

raitonoberu avatar Feb 09 '24 14:02 raitonoberu

The symlink is created by the meson post install script. This ignored the destdir variable and the link target was hardcoded. This script got rewritten to handle the installation of the types and the link target got fixed in the process, so it works now as intended when installing using meson. But this broke the package, because (at least in Arch but Void does something similar) it gets installed to a directory and gets moved over to /usr, which then breaks the symlink.

kotontrion avatar Feb 09 '24 15:02 kotontrion

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Jun 03 '24 01:06 github-actions[bot]

Sorry, I'm no longer interested in maintaining this package. If someone wants to pick it up, it should be as easy as updating the version and hash.

raitonoberu avatar Jun 10 '24 16:06 raitonoberu